Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LW-10808] Update cardano-node to 9.1.0 #3212

Merged
merged 6 commits into from
Aug 5, 2024

Conversation

michalrus
Copy link
Member

@michalrus michalrus commented Jul 17, 2024

This PR updates cardano-node to 9.1.0.

Todos

  • cardano-node 9.0.0
  • cardano-wallet v2024-07-19
  • cardano-node 9.1.0
  • cardano-wallet v2024-07-27

Screenshots

n/a

Testing Checklist


Review Checklist

Basics

  • PR assigned to the PR author(s)
  • input-output-hk/daedalus-dev and input-output-hk/daedalus-qa assigned as PR reviewers
  • If there are UI changes, Alexander Rukin assigned as an additional reviewer
  • PR has appropriate labels (release-vNext, feature/bug/chore, WIP)
  • PR link is added to a Jira ticket, ticket moved to In Review
  • PR is updated to the most recent version of the target branch (and there are no conflicts)
  • PR has a good description that summarizes all changes
  • PR contains screenshots (in case of UI changes)
  • CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
  • There are no missing translations (running yarn manage:translations produces no changes)
  • Text changes are proofread and approved (Jane Wild / Amy Reeve)
  • Japanese text changes are proofread and approved (Junko Oda)
  • Storybook works and no stories are broken (yarn storybook)
  • In case of dependency changes yarn.lock file is updated

Code Quality

  • Important parts of the code are properly commented and documented
  • Code is properly typed with typescript types
  • React components are split-up enough to avoid unnecessary re-renderings
  • Any code that only works in main process is neatly separated from components

Testing

  • New feature/change is covered by acceptance tests
  • New feature/change is manually tested and approved by QA team
  • All existing acceptance tests are still up-to-date
  • New feature/change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review

  • Update Slack QA thread by marking it with a green checkmark

@michalrus michalrus self-assigned this Jul 17, 2024
@michalrus michalrus changed the base branch from develop to chore/LW-10649-no-nix-chroot July 17, 2024 13:48
@michalrus michalrus force-pushed the chore/LW-10808-cardano-node-9 branch from 29fe18d to 9b05cda Compare July 18, 2024 07:38
@michalrus michalrus changed the title Chore/lw 10808 cardano node 9 [LW-10808] Update cardano-node to 9.0.0 Jul 18, 2024
@michalrus michalrus force-pushed the chore/LW-10808-cardano-node-9 branch 4 times, most recently from be9536b to 58aeb09 Compare July 18, 2024 10:06
@michalrus michalrus force-pushed the chore/LW-10808-cardano-node-9 branch from 58aeb09 to 426f842 Compare July 22, 2024 07:10
@michalrus michalrus force-pushed the chore/LW-10808-cardano-node-9 branch 2 times, most recently from e715a4a to e89b3f9 Compare July 25, 2024 12:48
@michalrus michalrus changed the title [LW-10808] Update cardano-node to 9.0.0 [LW-10808] Update cardano-node to 9.1.0 Jul 30, 2024
@tomislavhoracek tomislavhoracek self-requested a review August 2, 2024 09:51
Copy link
Contributor

@tomislavhoracek tomislavhoracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not competent to comment your code! But, I tested it with the latest HW updates and everything works perfectly. So, I'm approving it 💯 🧙‍♂️

Base automatically changed from chore/LW-10649-no-nix-chroot to develop August 5, 2024 09:22
@michalrus michalrus merged commit 821cd32 into develop Aug 5, 2024
3 of 4 checks passed
@michalrus michalrus deleted the chore/LW-10808-cardano-node-9 branch August 5, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants